drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StevenMPhillips <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3912: Common subexpression elimination
Date Tue, 20 Oct 2015 01:09:36 GMT
Github user StevenMPhillips commented on a diff in the pull request:

    https://github.com/apache/drill/pull/189#discussion_r42445825
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
---
    @@ -106,19 +163,32 @@ public HoldingContainer visitFunctionCall(FunctionCall call, ClassGenerator<?>
g
         @Override
         public HoldingContainer visitBooleanOperator(BooleanOperator op,
             ClassGenerator<?> generator) throws RuntimeException {
    +      HoldingContainer hc = getPrevious(op);
    +      if (hc != null) {
    +        return hc;
    +      }
    +      newScope();
    --- End diff --
    
    I think this should be possible, and probably less error prone.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message