drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3802: Throw unsupported error for Rollup...
Date Mon, 19 Oct 2015 22:47:02 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/209#discussion_r42435960
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
---
    @@ -305,6 +313,105 @@ public SqlNode visit(SqlCall sqlCall) {
         return sqlCall.getOperator().acceptCall(this, sqlCall);
       }
     
    +  private void checkRollupCubeGrpSets(SqlSelect sqlSelect) {
    +    final ExprFinder rollupCubeGrpSetsFinder = new ExprFinder(RollupCubeGrpSets);
    +    sqlSelect.accept(rollupCubeGrpSetsFinder);
    +    if (rollupCubeGrpSetsFinder.find()) {
    +      unsupportedOperatorCollector.setException(SqlUnsupportedException.ExceptionType.FUNCTION,
    --- End diff --
    
    I know that other Unsupported errors have pointed to JIRAs that are marked 'resolved fixed'
because they were about throwing such an exception.  Ideally, though, we should create an
enhancement JIRA (such as 'Add support for ROLLUP') and point to that in the error message.
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message