drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3742: Classpath scanning
Date Wed, 14 Oct 2015 20:52:34 GMT
Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r42051351
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
    @@ -82,10 +89,32 @@ public Controller getController() {
         return controller;
       }
     
    +  private void submit(ExecutorService p, final String name, final Closeable c) {
    --- End diff --
    
    I agree about removing closeQuietly but this sounds like a separate PR.
    This one is already bigger than it should, so I'm trying not to do too much refactoring
in it.
    I'm happy to do the closeQuietly refactoring as a follow up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message