drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3927: use OutOfMemoryException in more p...
Date Wed, 14 Oct 2015 20:20:27 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42047219
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
---
    @@ -369,24 +370,33 @@ AvaticaFactory getFactory() {
         return factory;
       }
     
    +  private static void closeOrWarn(final AutoCloseable autoCloseable, final String message,
final Logger logger) {
    --- End diff --
    
    should we make this public and move this to `org.apache.drill.common.AutoCloseables` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message