drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3742: Classpath scanning
Date Wed, 14 Oct 2015 18:50:19 GMT
Github user jacques-n commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
    @@ -82,10 +89,32 @@ public Controller getController() {
         return controller;
    +  private void submit(ExecutorService p, final String name, final Closeable c) {
    --- End diff --
    Can we move this to AutoCloseables?
    We can have the method be: AutoCloseables.closeQuietlyInParallel(AutoCloseable... closeables)
or something similar?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message