drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3742: Classpath scanning
Date Tue, 13 Oct 2015 23:23:23 GMT
Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r41939454
  
    --- Diff: common/src/main/java/org/apache/drill/common/logical/StoragePluginConfigBase.java
---
    @@ -17,30 +17,18 @@
      */
     package org.apache.drill.common.logical;
     
    -import java.util.List;
    +import java.util.Set;
     
    -import org.apache.drill.common.config.CommonConstants;
    -import org.apache.drill.common.config.DrillConfig;
    -import org.apache.drill.common.util.PathScanner;
    -
    -import com.google.common.base.Joiner;
    +import org.apache.drill.common.scanner.persistence.ScanResult;
     
     
     public abstract class StoragePluginConfigBase extends StoragePluginConfig {
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(StoragePluginConfigBase.class);
     
    -
    -  public synchronized static Class<?>[] getSubTypes(final DrillConfig config) {
    -    final List<String> packages =
    -        config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    -    final Class<?>[] pluginClasses =
    -        PathScanner.scanForImplementationsArr(StoragePluginConfig.class, packages);
    -    final String lineBrokenList =
    -        pluginClasses.length == 0
    -        ? "" : "\n\t- " + Joiner.on("\n\t- ").join(pluginClasses);
    -    logger.debug("Found {} storage plugin configuration classes: {}.",
    -                 pluginClasses.length, lineBrokenList);
    -    return pluginClasses;
    +  public synchronized static Set<Class<? extends StoragePluginConfig>> getSubTypes(final
ScanResult classpathScan) {
    --- End diff --
    
    If we needed it in the first place then... possibly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message