drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3742: Classpath scanning
Date Tue, 13 Oct 2015 23:10:55 GMT
Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r41938462
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
---
    @@ -53,12 +54,14 @@
        * @param config
        */
       public HiveFunctionRegistry(DrillConfig config) {
    -    Set<Class<? extends GenericUDF>> genericUDFClasses = PathScanner.scanForImplementations(GenericUDF.class,
null);
    +    // TODO: see if we can avoid this. We can't change the constructor right now.
    +    ScanResult classpathScan = ClassPathScanner.fromPrescan(config);
    --- End diff --
    
    no because fromPrescan has a cache (it keeps track of the last scan and reuses it if we
ask for the same thing), but that's far from ideal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message