drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3920 Add vector loading tests
Date Tue, 13 Oct 2015 18:47:33 GMT
Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/194#discussion_r41907790
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
    @@ -355,17 +353,19 @@ public void generateTestData(int values) { }
     
       @Override
       public void clear() {
    -    valueCount = 0;
    -    for (ValueVector v : getChildren()) {
    +    for (final ValueVector v : getChildren()) {
    --- End diff --
    
    But clear() doesn't call vectors.clear(). I seem to recall a problem with adding that
to clear() in the past. I'm worried this will introduce a regression, so I'd rather not take
that change on now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message