drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3921: Initialize the underlying record r...
Date Mon, 12 Oct 2015 18:09:49 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/197#discussion_r41784124
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
    @@ -130,6 +134,60 @@ public OperatorStats getStats() {
         return stats;
       }
     
    +
    --- End diff --
    
    Can we move create a pool for these delegate threads? The default can be empty but we'll
expand as needed. We also need to think about interruptions and errors. It might be better
if the actual method interface is Future<Result> and we allow the implementor pick when
to block. Guava has a abstract checked future that would probably solve most of these needs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message