drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mehant <...@git.apache.org>
Subject [GitHub] drill pull request: Initial version of RecordIterator and MergeJoi...
Date Sat, 10 Oct 2015 21:10:12 GMT
Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/190#discussion_r41701556
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordIterator.java
---
    @@ -0,0 +1,252 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.record;
    +
    +import java.util.Iterator;
    +import java.util.Map;
    +
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.exec.ops.OperatorContext;
    +import org.apache.drill.exec.physical.impl.sort.RecordBatchData;
    +import org.apache.drill.exec.record.RecordBatch.IterOutcome;
    +
    +import com.google.common.collect.ArrayListMultimap;
    +import com.google.common.collect.Lists;
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Range;
    +import com.google.common.collect.Sets;
    +import com.google.common.collect.TreeRangeMap;
    +
    +
    +public class RecordIterator implements VectorAccessible {
    --- End diff --
    
    RecordIterator seems to provide two useful abstractions
    
    1. Provide a abstraction to iterate over records (hiding away details about batch boundaries
etc)
    2. Provide an abstraction to be able to mark a record and go back and reiterate from that
record.
    
    What do you think about building the second abstraction on top of the first (MarkAndResetIterator
and RecordIterator)? I feel the first abstraction is very generic and can be used in most
operators cleaning out some of the redundant code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message