drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...
Date Fri, 02 Oct 2015 20:38:28 GMT
Github user cwestin commented on the pull request:

    https://github.com/apache/drill/pull/181#issuecomment-145149090
  
    I just squashed and pushed with the valueCount + 1 for the BaseRepeatedValueVector, along
with using valueCount in getBufferSizeFor() instead of getAccessor().getValueCount(). I opened
https://issues.apache.org/jira/browse/DRILL-3876 for the proper long term solution, and https://issues.apache.org/jira/browse/DRILL-3889
for the getBufferSize()/getBufferSizeFor() improvement. Can one of you please merge this for
1.2 now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message