drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Parquet meta
Date Fri, 02 Oct 2015 18:38:18 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/186#discussion_r41053297
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -716,6 +726,7 @@ public String toString() {
         return "ParquetGroupScan [entries=" + entries
             + ", selectionRoot=" + selectionRoot
             + ", numFiles=" + getEntries().size()
    +        + ", usedCache=" + usedMetadataCache
    --- End diff --
    
    Sounds good.  I'll make sure the docs are consistent with the behavior.
    Could you change the name to 'usedMetadataFile' (instead of 'use').   
    Rest of 3887 looks good to me.  +1 .    I have not reviewed the other changes.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message