drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Parquet meta
Date Fri, 02 Oct 2015 15:44:21 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/186#discussion_r41035620
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -716,6 +726,7 @@ public String toString() {
         return "ParquetGroupScan [entries=" + entries
             + ", selectionRoot=" + selectionRoot
             + ", numFiles=" + getEntries().size()
    +        + ", usedCache=" + usedMetadataCache
    --- End diff --
    
    This is a useful attribute; however usedCache might be misinterpreted to mean data cache.
usedMetadataCache is more explicit (although the term 'cache' itself is misleading - here
we are referring to file cache on disk, not in-memory). Another thing: is a boolean value
sufficient ? if there are 2 subdirectories and only one of them has the metadata cache, and
I query the parent directory: would the cache get used for one of the subdirectories and if
so, what would this flag indicate ? It sounds like if the parent directory has the cache,
then it will be true, otherwise false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message