drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...
Date Fri, 02 Oct 2015 02:00:15 GMT
Github user cwestin commented on the pull request:

    https://github.com/apache/drill/pull/181#issuecomment-144898125
  
    Parth:
    Re ObjectVector: I don't know what that's for. I just followed the pattern: getBufferSize()
already throws that exception.
    Re OUTPUT_MEMORY_LIMIT: what do you think? I tend to avoid adding more knobs, but I can
easily do that if you like (with the current 512MB as the default). Let me know soon, about
to kick off testing on Jason's suggested replacement of getBufferSize() implementations with
calls to getBufferSizeFor(). The problem I see here is that it will affect all flatten()s,
whether they need it or not. And, this isn't really the long term solution, which is really
to add projection capabilities so that we're not passing through the original record like
this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message