drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3874: flattening large JSON objects uses...
Date Fri, 02 Oct 2015 01:32:48 GMT
Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/181#discussion_r40985372
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
---
    @@ -123,6 +123,15 @@ public int getBufferSize() {
       }
     
       @Override
    +  public int getBufferSizeFor(int valueCount) {
    +    if (getAccessor().getValueCount() == 0) {
    +      return 0;
    +    }
    +
    +    return offsets.getBufferSizeFor(valueCount) + vector.getBufferSizeFor(valueCount);
    --- End diff --
    
    Based on setInitialValueCapacity(), I think you're right. Will do. (But I'm not going
to go back and patch the EBF for that, because it'll just be off by one offsets value, or
4 bytes, which isn't going to kill the emergency fix.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message