drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Thu, 01 Oct 2015 02:47:29 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r40875160
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
    @@ -179,6 +181,7 @@ public void validate(final OptionValue v) {
     
         public TypeValidator(final String name, final Kind kind, final OptionValue defValue)
{
           super(name);
    +      checkArgument(defValue.type == OptionType.SYSTEM, "Default value must be SYSTEM
type.");
    --- End diff --
    
    There are three other checkArguments in this changeset. However, I think they also refer
to dev mistakes instead of user errors.  Probably fine as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message