Return-Path: 
 <dev-return-16491-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CABC21037B
	for <apmail-drill-dev-archive@www.apache.org>;
 Thu, 17 Sep 2015 15:21:13 +0000 (UTC)
Received: (qmail 43659 invoked by uid 500); 17 Sep 2015 15:21:10 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 43605 invoked by uid 500); 17 Sep 2015 15:21:10 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 43594 invoked by uid 99); 17 Sep 2015 15:21:10 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Sep 2015 15:21:10 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 3CF8FE01F5; Thu, 17 Sep 2015 15:21:10 +0000 (UTC)
From: adeneche <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-160-drill@git.apache.org>
In-Reply-To: <git-pr-160-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3779: Fix NPE in mergeAndSpill().
 Add mo...
Content-Type: text/plain
Message-Id: <20150917152110.3CF8FE01F5@git1-us-west.apache.org>
Date: Thu, 17 Sep 2015 15:21:10 +0000 (UTC)

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/160#discussion_r39758626
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java ---
    @@ -478,28 +498,36 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup> batchGroups) throws Schem
             break;
           }
           BatchGroup batch = batchGroups.pollLast();
    +      assert batch != null;
    --- End diff --
    
    please add a message to the assertion, it will make our life easier if this assertion throws


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---