Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-120-drill@git.apache.org>
In-Reply-To: <git-pr-120-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-1942-hygiene
Content-Type: text/plain
Message-Id: <20150910181248.662E3E05E1@git1-us-west.apache.org>
Date: Thu, 10 Sep 2015 18:12:48 +0000 (UTC)

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/120#discussion_r39193558
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentManager.java ---
    @@ -38,36 +37,43 @@
        * @return True if the fragment has enough incoming data to be able to be run.
        * @throws FragmentSetupException, IOException
        */
    -  public abstract boolean handle(RawFragmentBatch batch) throws FragmentSetupException, IOException;
    +  boolean handle(RawFragmentBatch batch) throws FragmentSetupException, IOException;
     
       /**
        * Get the fragment runner for this incoming fragment. Note, this can only be requested once.
        *
        * @return
        */
    -  public abstract FragmentExecutor getRunnable();
    +  FragmentExecutor getRunnable();
    +
    +  void cancel();
     
    -  public abstract void cancel();
    +  /**
    +   * Find out if the FragmentManager has been cancelled.
    +   *
    +   * @return true if the FragmentManager has been cancelled.
    +   */
    +  boolean isCancelled();
    --- End diff --
    
    I don't see this method being used anywhere. Is this change intended?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---