Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jaltekruse <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-98-drill@git.apache.org>
In-Reply-To: <git-pr-98-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3497: Throw
 UserException#validationErro...
Content-Type: text/plain
Message-Id: <20150903154441.6D697E7E80@git1-us-west.apache.org>
Date: Thu,  3 Sep 2015 15:44:41 +0000 (UTC)

Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/98#discussion_r38660966
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/ControlsInjectionUtil.java ---
    @@ -74,7 +75,7 @@ public static void setControls(final UserSession session, final String controls)
     
         final OptionManager options = session.getOptions();
         try {
    -      options.getAdmin().validate(opValue);
    +      SystemOptionManager.getValidator(DRILLBIT_CONTROL_INJECTIONS).validate(opValue);
    --- End diff --
    
    This could just be a reference to the validator itself, as it is also public and static, rather than looking it up by name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---