drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 2274: Unable to allocate sv2 buffer afte...
Date Mon, 28 Sep 2015 15:47:05 GMT
GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/172

    Drill 2274: Unable to allocate sv2 buffer after repeated attempts : JOIN, Order by used
in query

    main improvements are:
    - when external sort cannot allocate a new SV2, it spills `spilledBatchGroups` and not
`batchGroups` to make sure it frees memory from the sort's allocator
    - `copierAllocator` is closed as soon as possible to make sure more memory is available
for the sort

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-2274

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit 3b4e82dc22ee96bdf20f64f4286f8f4312d8cf8c
Author: adeneche <adeneche@gmail.com>
Date:   2015-09-21T18:59:56Z

    DRILL-2274: Unable to allocate sv2 buffer after repeated attempts : JOIN, Order by used
in query
    
    - when ExternalSortBatch.newSV2() couldn't allocate a new SV2 it spills the spilledBatchGroups
instead of batchGroups, otherwise no memory will be released for the sort's allocator
    - copierAllocator is closed as soon as possible to free more memory for the sort

commit ab31323956b3c238a03ff0528a025bbe5a109de3
Author: adeneche <adeneche@gmail.com>
Date:   2015-09-21T19:00:38Z

    code cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message