drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3732: Drill leaks memory if external sor...
Date Sat, 05 Sep 2015 00:11:19 GMT
GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/147

    DRILL-3732: Drill leaks memory if external sort hits out of disk spac…

    …e exception
    
    - ExternalSort.mergeAndSpill() cleans all it's data in case an errors occurs while it's
spilling to disk
    - made BatchGroup AutoCloseable so it can easily be closed with AutoCloseables.close()
if an error occurs
    - added injection site while External sort is spilling to disk
    - added unit test that forces a 2 batch query to spill to disk and injects an exception
while it does so

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-3732

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #147
    
----
commit a113d9a5e5d434715159c01e97ff7ffa4bad9b38
Author: adeneche <adeneche@gmail.com>
Date:   2015-09-05T00:10:17Z

    DRILL-3732: Drill leaks memory if external sort hits out of disk space exception
    
    - ExternalSort.mergeAndSpill() cleans all it's data in case an errors occurs while it's
spilling to disk
    - made BatchGroup AutoCloseable so it can easily be closed with AutoCloseables.close()
if an error occurs
    - added injection site while External sort is spilling to disk
    - added unit test that forces a 2 batch query to spill to disk and injects an exception
while it does so

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message