drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3566: Fix: PreparedStatement.executeQuer...
Date Thu, 03 Sep 2015 21:52:59 GMT
GitHub user dsbos opened a pull request:

    https://github.com/apache/drill/pull/143

    DRILL-3566: Fix:  PreparedStatement.executeQuery() got ClassCastException.

    Main:
    Restored DrillResultSetImpl(...)'s statement parameter from overly
    restrictive DrillStatementImpl to AvaticaStatement and removed caller
    cast that was throwing.  (Relatedly, adjusted getStatement() and moved
    internal casting from statement to connection.)
    
    Added basic test of querying via PreparedStatement.  [PreparedStatementTest]
    Added some case test of statement-creation methods.  [ConnectionTest]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dsbos/incubator-drill bugs/drill-3566

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 1a870538c66fa59070facce7e2a4342d9869b51e
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-07-28T02:27:50Z

    DRILL-3566: Fix:  PreparedStatement.executeQuery() got ClassCastException.
    
    Main:
    Restored DrillResultSetImpl(...)'s statement parameter from overly
    restrictive DrillStatementImpl to AvaticaStatement and removed caller
    cast that was throwing.  (Relatedly, adjusted getStatement() and moved
    internal casting from statement to connection.)
    
    Added basic test of querying via PreparedStatement.  [PreparedStatementTest]
    Added some case test of statement-creation methods.  [ConnectionTest]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message