drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deneche A. Hakim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-3811) AtomicRemainder incorrectly accounts for transferred allocations
Date Mon, 21 Sep 2015 02:20:04 GMT
Deneche A. Hakim created DRILL-3811:
---------------------------------------

             Summary: AtomicRemainder incorrectly accounts for transferred allocations
                 Key: DRILL-3811
                 URL: https://issues.apache.org/jira/browse/DRILL-3811
             Project: Apache Drill
          Issue Type: Bug
          Components: Execution - Relational Operators
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim


when an allocator takes ownership of a buffer, AtomicRemainder.forceGet(int) is called to
account for the extra memory of the buffer, but when the allocator exceeds it's maximum allocated
memory it accounts for it incorrectly. In the following code, {{availableShared.andAndGet(size)}}
should actually receive {{-size}}:

{code}
public boolean forceGet(long size) {
    if (get(size, this.applyFragmentLimit)) {
      return true;
    } else {
      availableShared.addAndGet(size);
      if (parent != null) {
        parent.forceGet(size);
      }
      return false;
    }
  }
{code}

I was able to reproduce the issue in a simple unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message