drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3257: Disable FilterSetOpTransposeRule, ...
Date Tue, 29 Sep 2015 19:12:08 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/176#discussion_r40715318
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java ---
    @@ -542,7 +542,9 @@ public void testFilterPushDownOverUnionAll() throws Exception {
                 ".*Filter.*\n" +
                     ".*Scan"};
         final String[] excludedPlan = {"Filter.*\n.*UnionAll"};
    -    PlanTestBase.testPlanMatchingPatterns(query, expectedPlan, excludedPlan);
    +    // Add the plan verification after FilterSetOpTransposeRule and DrillProjectSetOpTransposeRule
    +    // are enabled
    +    // PlanTestBase.testPlanMatchingPatterns(query, expectedPlan, excludedPlan);
    --- End diff --
    
    Since these are the only plan verification tests for Union, I suggest you keep the plan
verification tests (with the modified plan) and file a JIRA for re-enabling the rules.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message