drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 2274: Unable to allocate sv2 buffer afte...
Date Mon, 28 Sep 2015 21:07:22 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/172#discussion_r40605696
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
    @@ -615,11 +608,18 @@ private SelectionVector2 newSV2() throws OutOfMemoryException, InterruptedExcept
         SelectionVector2 sv2 = new SelectionVector2(oContext.getAllocator());
         if (!sv2.allocateNewSafe(incoming.getRecordCount())) {
           try {
    -        spilledBatchGroups.addFirst(mergeAndSpill(batchGroups));
    +        // Not being able to allocate sv2 means this operator's allocator reached it's
maximum capacity.
    +        // Spilling this.batchGroups won't help here as they are owned by another operator,
    --- End diff --
    
    Can you change this to 'owned by upstream operator'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message