drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1457: Push Limit past through UnionExcha...
Date Fri, 25 Sep 2015 23:28:39 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/169#discussion_r40484865
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
    @@ -0,0 +1,64 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner.physical;
    +
    +import org.apache.calcite.plan.RelOptRule;
    +import org.apache.calcite.plan.RelOptRuleCall;
    +import org.apache.calcite.rel.RelNode;
    +import org.apache.calcite.rex.RexLiteral;
    +import org.apache.calcite.rex.RexNode;
    +import org.apache.drill.exec.planner.logical.RelOptHelper;
    +
    +import java.math.BigDecimal;
    +
    +public class LimitUnionExchangeTransposeRule extends Prule{
    +  public static final RelOptRule INSTANCE = new LimitUnionExchangeTransposeRule();
    +
    +  private LimitUnionExchangeTransposeRule() {
    +    super(RelOptHelper.some(LimitPrel.class, RelOptHelper.any(UnionExchangePrel.class)),
"LimitUnionExchangeTransposeRule");
    +  }
    +
    +  @Override
    +  public boolean matches(RelOptRuleCall call) {
    +    final LimitPrel limit = (LimitPrel) call.rel(0);
    +
    +    return !limit.isPushDown();
    +  }
    +
    +  @Override
    +  public void onMatch(RelOptRuleCall call) {
    +    final LimitPrel limit = (LimitPrel) call.rel(0);
    +    final UnionExchangePrel unionExchangePrel = (UnionExchangePrel) call.rel(1);
    +
    +    RelNode child = unionExchangePrel.getInput();
    +
    +    final int offset = limit.getOffset() != null ? Math.max(0, RexLiteral.intValue(limit.getOffset()))
: 0;
    +    final int fetch = limit.getFetch() != null?  Math.max(0, RexLiteral.intValue(limit.getFetch()))
: 0;
    --- End diff --
    
    Thanks, Julian!
    
    Good point about the case of fetch == null.  When fetch == null, the query should return
all the remaining rows starting from offset. In such case, seems it does not make sense to
push Limit operator, as the underline operator has to go through all the records.
    
    I modified the rule, so that it will not push limit when fetch == null. I also made change
to the row count estimation for the case of fetch == null.
    
    For Sean's comment, this patch is for a special case in Drill's physical planing to handle
limit on top of UnionExchange. For other regular relational operator, as Julian pointed, Calcite-831
will have the optimization rules and Drill could re-use them once Calcite-831 is done (Drill-636
was opened for those cases).
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message