drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianhyde <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1457: Push Limit past through UnionExcha...
Date Fri, 25 Sep 2015 16:12:57 GMT
Github user julianhyde commented on a diff in the pull request:

    https://github.com/apache/drill/pull/169#discussion_r40446899
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
    @@ -36,11 +36,17 @@
     public abstract class DrillLimitRelBase extends SingleRel implements DrillRelNode {
       protected RexNode offset;
       protected RexNode fetch;
    +  private boolean pushDown;  // whether limit has been push past its child.
    --- End diff --
    
    Actually sort and aggregate have some of this behavior too. You can do a partial sort
or partial aggregate in the children but then you need to combine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message