drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwestin <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3811: AtomicRemainder incorrectly accoun...
Date Tue, 22 Sep 2015 16:36:18 GMT
Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/163#discussion_r40109454
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/memory/AtomicRemainder.java
---
    @@ -76,16 +74,17 @@ public void setLimit(long limit) {
     
       }
       /**
    -   * Automatically allocate memory. This is used when an actual allocation happened to
be larger than requested. This
    -   * memory has already been used up so it must be accurately accounted for in future
allocations.
    +   * Automatically allocate memory. This is used when an actual allocation happened to
be larger than requested, or when
    +   * a buffer has it's ownership passed to another allocator.<br>
    +   * This memory has already been used up so it must be accurately accounted for in future
allocations.
        *
    -   * @param size
    +   * @param size extra allocated memory that needs to be accounted for
        */
       public boolean forceGet(long size) {
         if (get(size, this.applyFragmentLimit)) {
           return true;
         } else {
    -      availableShared.addAndGet(size);
    +      availableShared.addAndGet(-size);
    --- End diff --
    
    This call is used when transferring ownership from the RPC layer to a receiving fragment
-- and you can't refuse it -- the RPC layer has to hand it off. The problem is that the accounting
for buffer ownership transfer and sharing is questionable in the original allocator. This
is probably the best that can be done for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message