drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau" <jacques.dr...@gmail.com>
Subject Re: Review Request 38359: DRILL-3201: Add authentication and authorization to Drill Web client
Date Tue, 22 Sep 2015 15:41:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38359/#review99997
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java (line
185)
<https://reviews.apache.org/r/38359/#comment157067>

    If you permissions annotations on the Login/Out resources, you shouldn't need this.



exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java (line
35)
<https://reviews.apache.org/r/38359/#comment157063>

    can we make this /login



exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java (line
42)
<https://reviews.apache.org/r/38359/#comment157064>

    how about /login/error



exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java (line
49)
<https://reviews.apache.org/r/38359/#comment157065>

    /logout



exec/java-exec/src/main/resources/rest/log/login.ftl (line 13)
<https://reviews.apache.org/r/38359/#comment157066>

    Let's not create a separate file for the ui framework. We should share the existing framework
we use everywhere else (via ftl include)


- Jacques Nadeau


On Sept. 16, 2015, 7:06 a.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38359/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 7:06 a.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Jason Altekruse.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Use jetty's SecurityHandler (with FormAuthenticator and LoginService) to enforce authentication.
Use jersey's annotations to enforece authorizations.
> 
> 
> Diffs
> -----
> 
>   distribution/src/resources/drill-override-example.conf 805d6e9 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 0f6a5bb 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
8c14587 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java 3e972b4

>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogOutServlet.java PRE-CREATION

>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/MetricsResources.java
28a292b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
145a476 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java ee31929

>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StatusResources.java
c99c49b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
49f387c 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ThreadsResources.java
def5acb 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ViewableWithPermissions.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AbstractDrillLoginService.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousAuthenticator.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousLoginService.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillRestLoginService.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
6656bf6 
>   exec/java-exec/src/main/resources/drill-module.conf dbe449a 
>   exec/java-exec/src/main/resources/rest/generic.ftl 9df2424 
>   exec/java-exec/src/main/resources/rest/log/login.ftl PRE-CREATION 
>   exec/java-exec/src/main/resources/rest/static/img/apache-drill-logo.png PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/38359/diff/
> 
> 
> Testing
> -------
> 
> Currently testing is manual. Rest based unittests are coming in DRILL-2965.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message