drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Mon, 21 Sep 2015 21:16:15 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r40027080
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
    @@ -102,6 +119,29 @@ public void setOption(OptionValue value) {
       }
     
       @Override
    +  public void deleteOption(final String name, final OptionType type) {
    +    try {
    +      SystemOptionManager.getValidator(name); // ensure the option exists
    +    } catch (final IllegalArgumentException e) {
    +      throw UserException.validationError(e)
    +        .build(logger);
    +    }
    +
    +    // fallback if unable to delete locally
    +    if (!deleteLocalOption(name, type)) {
    --- End diff --
    
    Implementations of OptionManager are required to be case insensitive to option names (mentioned
in the OptionManager class docs). Calling ```name.toLowerCase()``` in this one place is insufficient
to ensure *implementation will always be case insensitive.*


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message