drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Mon, 21 Sep 2015 20:46:38 GMT
Github user adeneche commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SessionOptionManager.java
    @@ -20,14 +20,21 @@
     import com.google.common.base.Predicate;
     import com.google.common.collect.Collections2;
     import org.apache.commons.lang3.tuple.ImmutablePair;
    +import org.apache.drill.common.exceptions.UserException;
     import org.apache.drill.common.map.CaseInsensitiveMap;
     import org.apache.drill.exec.rpc.user.UserSession;
    +import org.apache.drill.exec.server.options.OptionValue.OptionType;
     import java.util.Collection;
     import java.util.Map;
    - * {@link OptionManager} that holds options within {@link org.apache.drill.exec.rpc.user.UserSession}
    + * {@link OptionManager} that holds options within {@link org.apache.drill.exec.rpc.user.UserSession}
context. Options
    + * set at the session level only apply to queries that you run during the current Drill
connection. Session level
    + * settings override system level settings.
    + *
    + * NOTE that currently, the effects of deleting a short lived option (see {@link OptionValidator#isShortLived})
    + * undefined.
    --- End diff --
    No, I meant could you explain what you mean by _undefined_ effects. I think you mean if
we set a short lived session, for example we inject an exception, then try to delete it, depending
on where the exception was injected the reset query could either succeed or the exception
could actually be thrown in the reset query itself.
    Just improve the comment to explain what you mean

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message