drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Mon, 21 Sep 2015 20:35:11 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r40022217
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SessionOptionManager.java
---
    @@ -20,14 +20,21 @@
     import com.google.common.base.Predicate;
     import com.google.common.collect.Collections2;
     import org.apache.commons.lang3.tuple.ImmutablePair;
    +import org.apache.drill.common.exceptions.UserException;
     import org.apache.drill.common.map.CaseInsensitiveMap;
     import org.apache.drill.exec.rpc.user.UserSession;
    +import org.apache.drill.exec.server.options.OptionValue.OptionType;
     
     import java.util.Collection;
     import java.util.Map;
     
     /**
    - * {@link OptionManager} that holds options within {@link org.apache.drill.exec.rpc.user.UserSession}
context.
    + * {@link OptionManager} that holds options within {@link org.apache.drill.exec.rpc.user.UserSession}
context. Options
    + * set at the session level only apply to queries that you run during the current Drill
connection. Session level
    + * settings override system level settings.
    + *
    + * NOTE that currently, the effects of deleting a short lived option (see {@link OptionValidator#isShortLived})
are
    + * undefined.
    --- End diff --
    
    Should I add a TODO and create a ticket?
    (personally I don't think this is worth a JIRA yet)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message