drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Thu, 17 Sep 2015 22:03:30 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r39804781
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java ---
    @@ -46,19 +48,124 @@ public void testOptions() throws Exception{
       @Test
       public void checkValidationException() throws Exception {
         thrownException.expect(new UserExceptionMatcher(VALIDATION));
    -    test(String.format("ALTER session SET `%s` = '%s';", ExecConstants.SLICE_TARGET,
"fail"));
    +    test("ALTER session SET `%s` = '%s';", SLICE_TARGET, "fail");
       }
     
       @Test // DRILL-3122
       public void checkChangedColumn() throws Exception {
    -    test(String.format("ALTER session SET `%s` = %d;", ExecConstants.SLICE_TARGET,
    +    test(String.format("ALTER session SET `%s` = %d;", SLICE_TARGET,
           ExecConstants.SLICE_TARGET_DEFAULT));
         testBuilder()
    -        .sqlQuery(String.format("SELECT status FROM sys.options WHERE name = '%s' AND
type = 'SESSION'", ExecConstants.SLICE_TARGET))
    +        .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND type = 'SESSION'",
SLICE_TARGET)
             .unOrdered()
             .baselineColumns("status")
             .baselineValues("DEFAULT")
             .build()
             .run();
       }
    +
    +  @Test
    +  public void setAndResetSessionOption() throws Exception {
    +    // check unchanged
    +    testBuilder()
    +      .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND type = 'SESSION'",
SLICE_TARGET)
    +      .unOrdered()
    +      .expectsEmptyResultSet()
    +      .build()
    +      .run();
    +
    +    // change option
    +    test("SET `%s` = %d;", SLICE_TARGET, 10);
    +    // check changed
    +    test("SELECT status, type, name FROM sys.options WHERE type = 'SESSION';");
    +    testBuilder()
    +      .sqlQuery("SELECT num_val FROM sys.options WHERE name = '%s' AND type = 'SESSION'",
SLICE_TARGET)
    +      .unOrdered()
    +      .baselineColumns("num_val")
    +      .baselineValues((long) 10)
    +      .build()
    +      .run();
    +
    +    // reset option
    +    test("RESET `%s`;", SLICE_TARGET);
    +    // check reverted
    +    testBuilder()
    +      .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND type = 'SESSION'",
SLICE_TARGET)
    +      .unOrdered()
    +      .expectsEmptyResultSet()
    +      .build()
    +      .run();
    +  }
    +
    +  @Test
    +  public void setAndResetSystemOption() throws Exception {
    --- End diff --
    
    please add a test where both _SYSTEM_ and _SESSION_ options are changed, and confirm the
reset is working as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message