drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET statem...
Date Thu, 17 Sep 2015 21:48:56 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r39803386
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SessionOptionManager.java
---
    @@ -46,6 +47,33 @@ public SessionOptionManager(final OptionManager systemOptions, final
UserSession
       }
     
       @Override
    +  public void deleteOption(final String name, final OptionValue.OptionType type) {
    +    if (type == OptionValue.OptionType.SESSION) {
    +      try { // ensure option exists
    --- End diff --
    
    Yes, the fallback for a SessionOptionManager is a SystemOptionManager.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message