drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3779: Fix NPE in mergeAndSpill(). Add mo...
Date Thu, 17 Sep 2015 15:21:10 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/160#discussion_r39758626
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
    @@ -478,28 +498,36 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup> batchGroups)
throws Schem
             break;
           }
           BatchGroup batch = batchGroups.pollLast();
    +      assert batch != null;
    --- End diff --
    
    please add a message to the assertion, it will make our life easier if this assertion
throws


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message