drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3732: Drill leaks memory if external sor...
Date Wed, 16 Sep 2015 17:40:24 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/147#discussion_r39660969
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
    @@ -506,7 +508,7 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup> batchGroups)
throws Schem
     
         String outputFile = Joiner.on("/").join(dirs.next(), fileName, spillCount++);
         BatchGroup newGroup = new BatchGroup(c1, fs, outputFile, oContext.getAllocator());
    -
    +    boolean threw = true;
    --- End diff --
    
    Can you add comments on what is the significance of this flag ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message