drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3767: SchemaPath.getCompoundPath(String....
Date Tue, 15 Sep 2015 15:40:58 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/155#discussion_r39526289
  
    --- Diff: common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -54,15 +50,16 @@ public static SchemaPath getSimplePath(String name) {
       }
     
       public static SchemaPath getCompoundPath(String... strings) {
    -    List<String> paths = Arrays.asList(strings);
    -    Collections.reverse(paths);
         NameSegment s = null;
    -    for (String p : paths) {
    -      s = new NameSegment(p, s);
    +    final int length = strings.length;
    +    // loop through strings in reverse order
    +    for (int i = 0; i < length; i++) {
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message