drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: Upgrade to guava 18.0
Date Tue, 15 Sep 2015 02:36:19 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/157#discussion_r39469304
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
---
    @@ -66,8 +67,8 @@ public DataTunnel getTunnel(DrillbitEndpoint endpoint) {
         return new DataTunnel(newManager);
       }
     
    -  public void close() {
    -    Closeables.closeQuietly(server);
    +  public void close() throws IOException {
    --- End diff --
    
    You can use `AutoCloseables.close(server, logger)` which catch any exception and log it
as a warning in the passed logger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message