drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aleph-zero <...@git.apache.org>
Subject [GitHub] drill pull request: Upgrade to guava 18.0
Date Mon, 14 Sep 2015 21:45:45 GMT
Github user aleph-zero commented on a diff in the pull request:

    https://github.com/apache/drill/pull/157#discussion_r39451513
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnection.java
---
    @@ -110,7 +110,9 @@ public boolean equals(Object obj) {
     
       public void shutdownIfClient() {
         if (bus.isClient()) {
    -      Closeables.closeQuietly(bus);
    +      try {
    +        Closeables.close(bus, true);
    +      } catch (Exception e) { /* do nothing */ }
    --- End diff --
    
    So how about if we change to ```public void shutdownIfClient() throws IOException``` and
remove the ```catch```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message