drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aleph-zero <...@git.apache.org>
Subject [GitHub] drill pull request: Upgrade to guava 18.0
Date Mon, 14 Sep 2015 21:36:50 GMT
Github user aleph-zero commented on a diff in the pull request:

    https://github.com/apache/drill/pull/157#discussion_r39450581
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
---
    @@ -66,8 +67,8 @@ public DataTunnel getTunnel(DrillbitEndpoint endpoint) {
         return new DataTunnel(newManager);
       }
     
    -  public void close() {
    -    Closeables.closeQuietly(server);
    +  public void close() throws IOException {
    --- End diff --
    
    Yes, ```Closeables.close(..., true)``` does indeed swallow any IOException. However, the
```Closeables.close()``` method still declares that it throws IOException and so we have to
deal with that somehow. 
    
    So what would you recommend? We can either add a redundant catch block for IOException
that we know will never be executed, or we can modify the ```DataConnectionManager.close()```
to declare it to throw IOE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message