drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3767: SchemaPath.getCompoundPath(String....
Date Sun, 13 Sep 2015 02:56:14 GMT
Github user adeneche commented on a diff in the pull request:

    --- Diff: common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -54,15 +50,16 @@ public static SchemaPath getSimplePath(String name) {
       public static SchemaPath getCompoundPath(String... strings) {
    --- End diff --
    The change I made removes the side effect. Do you mean I should add a description of the
method's purpose ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message