drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3767: SchemaPath.getCompoundPath(String....
Date Sun, 13 Sep 2015 02:55:38 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/155#discussion_r39343893
  
    --- Diff: common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -220,9 +214,6 @@ public boolean contains(Object obj) {
         }
     
         SchemaPath other = (SchemaPath) obj;
    -    if (rootSegment == null) {
    --- End diff --
    
    One can indeed pass a null rootSegment to the constructor. If this is something that shouldn't
happen, maybe I can just add an assertion in the constructors, otherwise I will revert back
the change in this function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message