drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3767: SchemaPath.getCompoundPath(String....
Date Sat, 12 Sep 2015 22:29:29 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/155#discussion_r39342062
  
    --- Diff: common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -54,15 +50,16 @@ public static SchemaPath getSimplePath(String name) {
       }
     
       public static SchemaPath getCompoundPath(String... strings) {
    --- End diff --
    
    Given the concern expressed in the commit message, do you think a Javadoc should be provided?
    
    Or were you simply referencing that the logic inside the method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message