drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1942-hygiene:
Date Fri, 11 Sep 2015 21:58:19 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/133#discussion_r39322427
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
    @@ -481,30 +466,28 @@ public HashJoinProbe setupHashJoinProbe() throws ClassTransformationException,
I
               outputType = inputType;
             }
     
    -        ValueVector v = container.addOrGet(MaterializedField.create(vv.getField().getPath(),
outputType));
    +        final ValueVector v = container.addOrGet(MaterializedField.create(vv.getField().getPath(),
outputType));
             if (v instanceof AbstractContainerVector) {
               vv.getValueVector().makeTransferPair(v);
               v.clear();
             }
     
    -        JVar inVV = g.declareVectorValueSetupAndMember("probeBatch", new TypedFieldId(inputType,
false, fieldId));
    -        JVar outVV = g.declareVectorValueSetupAndMember("outgoing", new TypedFieldId(outputType,
false, outputFieldId));
    +        final JVar inVV = g.declareVectorValueSetupAndMember("probeBatch", new TypedFieldId(inputType,
false, fieldId));
    +        final JVar outVV = g.declareVectorValueSetupAndMember("outgoing", new TypedFieldId(outputType,
false, outputFieldId));
     
             g.getEvalBlock().add(outVV.invoke("copyFromSafe").arg(probeIndex).arg(outIndex).arg(inVV));
     
             fieldId++;
             outputFieldId++;
           }
    -      recordCount = left.getRecordCount();
         }
     
    -    HashJoinProbe hj = context.getImplementationClass(cg);
    -
    +    final HashJoinProbe hj = context.getImplementationClass(cg);
    --- End diff --
    
    you can also change this to:
    ```
    return context.getImplementationClass(cg);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message