drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1942-hygiene:
Date Fri, 11 Sep 2015 21:32:56 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/133#discussion_r39320024
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java ---
    @@ -65,7 +63,7 @@ public DrillBuf replace(DrillBuf old, int newSize) {
         if (managedBuffers.remove(old.memoryAddress()) == null) {
           throw new IllegalStateException("Tried to remove unmanaged buffer.");
         }
    -    old.release();
    +    old.release(1);
    --- End diff --
    
    same as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message