drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1942-hygiene
Date Thu, 10 Sep 2015 21:14:06 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/120#discussion_r39214700
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
    @@ -211,8 +220,11 @@ public TransferPair makeTransferPair(ValueVector to) {
     
       public void transferTo(BitVector target) {
         target.clear();
    +    if (target.data != null) {
    +      target.data.release();
    --- End diff --
    
    I think the current form is good. I'll merge the patch at it is. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message