drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: Update Calcite and Add Test cases
Date Thu, 10 Sep 2015 18:47:35 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/152#discussion_r39198057
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java ---
    @@ -379,6 +379,16 @@ protected static void parseErrorHelper(final String testSqlQuery)
throws Excepti
         errorMsgTestHelper(testSqlQuery, UserBitShared.DrillPBError.ErrorType.PARSE.name());
       }
     
    +  /**
    +   * Utility method which tests given query produces a {@link UserException}
    +   * with {@link org.apache.drill.exec.proto.UserBitShared.DrillPBError.ErrorType}
    +   * being DrillPBError.ErrorType.VALIDATION the given message.
    +   * @param testSqlQuery Test query
    +   */
    +  protected static void validationErrorHelper(final String testSqlQuery) throws Exception
{
    --- End diff --
    
    Oh. cool. I have never known we could do that :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message