drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau" <jacques.dr...@gmail.com>
Subject Re: Review Request 37893: DRILL-3718: TSV reader fails when "" appears
Date Wed, 09 Sep 2015 00:10:57 GMT


> On Sept. 8, 2015, 3:47 a.m., Jacques Nadeau wrote:
> > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java, line 1105
> > <https://reviews.apache.org/r/37893/diff/3/?file=1059076#file1059076line1105>
> >
> >     Please move text tests to their own file. I believe we already have a TestTextReader.
> >     
> >     Can you also please add another file with a different format to prove that this
fix works for multiple delimiters?
> >     
> >     Lastly, you should a small comment to the condition where you've added it.
> 
> Sean Hsuan-Yi Chu wrote:
>     1. Done
>     2. By "multiple", I am assuming you meant like: "a"\t\t"a"? (Please see the diff)
>     3. Done

I mean try with something other than a tab as the delimiter.  For example, try it with a space
delimiter.


- Jacques


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37893/#review97962
-----------------------------------------------------------


On Sept. 9, 2015, 12:09 a.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37893/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 12:09 a.m.)
> 
> 
> Review request for drill, Jacques Nadeau and Mehant Baid.
> 
> 
> Bugs: DRILL-3718
>     https://issues.apache.org/jira/browse/DRILL-3718
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> For TSV files, if the TextReader reads a double quote, it would keep scanning until it
gets the second double quote.
> 
> However, even getting the second double quote, the current reader will keep going in
order to trim the space (i.e., ' '). 
> 
> In tsv, there is no need to trim '\t' (tab), which is used to separate fields.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java
3899509 
>   exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java d15cff2 
>   exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java
e63e528 
>   exec/java-exec/src/test/resources/store/text/WithQuote.tsv PRE-CREATION 
>   exec/java-exec/src/test/resources/store/text/WithQuoteMultiDelimiters.tsv PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/37893/diff/
> 
> 
> Testing
> -------
> 
> All
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message