drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: First pass at test re-factoring
Date Tue, 08 Sep 2015 21:46:40 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/135#discussion_r38984610
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/DrillIntegrationTestBase.java
---
    @@ -80,221 +93,303 @@
         }
       };
     
    -  public final TestRule resetWatcher = new TestWatcher() {
    -    @Override
    -    protected void failed(Throwable e, Description description) {
    -      try {
    -        resetClientAndBit();
    -      } catch (Exception e1) {
    -        throw new RuntimeException("Failure while resetting client.", e1);
    -      }
    -    }
    -  };
    -
    -  protected static DrillClient client;
    -  protected static Drillbit[] bits;
    -  protected static RemoteServiceSet serviceSet;
    -  protected static DrillConfig config;
    -  protected static BufferAllocator allocator;
    +  /* *** Cluster Scope Settings *** */
    +
    +  public static final int MIN_NUM_DRILLBITS     = 1;
    +  public static final int MAX_NUM_DRILLBITS     = 5;
    +  public static final int DEFAULT_NUM_DRILLBITS = 2;
    --- End diff --
    
    any particular reason you changed default num drillbits from 1 to 2 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message