drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 37910: DRILL-3622: When user authentication is enabled, enforce admin privileges to update SYSTEM options
Date Tue, 08 Sep 2015 16:35:08 GMT


> On Sept. 8, 2015, 8:57 a.m., Jason Altekruse wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java, line 265
> > <https://reviews.apache.org/r/37910/diff/1/?file=1058412#file1058412line265>
> >
> >     These should both be updated to be subclasses of AdminOptionValidator, so that
we can veryify that the string passed is the correct format when it is set.

Currently the format is very loose, basically a comma separated list of users or groups. Not
sure what we want to validate here. Enforcing a certain format on the user name is risky given
the format of userName/groupName is depended on the underlying system.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37910/#review97760
-----------------------------------------------------------


On Aug. 28, 2015, 4 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37910/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 4 p.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Please see DRILL-3622 for details.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 140e9a8 
>   exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java c3cd4e6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandler.java
19c9f7f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
2d41740 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
b8597b7 
>   exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java aa766be

>   exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java d428920 
>   exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorTestImpl.java
c89471f 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/RootResource.java 59adad9

> 
> Diff: https://reviews.apache.org/r/37910/diff/
> 
> 
> Testing
> -------
> 
> Added unittest. Regression suites currently running.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message